Repository navigation
Conversation
Owner
|
Thank you for the PR. There are currently no plans to merge this feature. mygo will be used to support macOS and Windows platforms in the future. |
Owner
|
The new version is now supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
atvloadly only runs in Docker on Linux/OpenWrt. On a Mac, Docker Desktop or OrbStack puts the service behind a VM network, so mDNS discovery is unreliable and the Mac's own usbmuxd is out of reach (see #96).
This PR runs the service natively on Apple Silicon and Intel Macs. It uses the system mDNS and the system usbmuxd, so Docker, Avahi, D-Bus and usbmuxd2 are not needed. Linux and Docker behaviour is unchanged.
How it works
npm run build,go build); no build script is added. Your PlumeImpactor fork'sv2.7.0-patch.1release, which the Docker image uses, has no macOSplumesign, sodoc/macos.mddocuments building it from source with Cargo andomnisette/aos-kitfor macOS's native Anisette. Everything is built in the ignoredbuild/directory.plumesignplaced next to theatvloadlybinary is used beforePATH, so the bundle works from any working directory. A missing engine is reported at startup instead of on the first install.~/Library/Application Support/atvloadly, no longer derived from the binary name. PlumeImpactor state followsplumesign's ownXDG_CONFIG_HOMEhandling, and external certificate installs isolateXDG_CONFIG_HOMEas well asHOME. CoreADI downloads are Linux-only (macOS uses the system Anisette) and are written to the engine's data directory./var/db/lockdown, readable only by_usbmuxd, so devices paired over USB never matched their_apple-mobdev2announcements. atvloadly now reads the records through the system usbmuxd socket (ListDevicesandReadPairRecord), decoding only the Wi-Fi MAC address. Nosudois needed and the records are never modified. Because usbmuxd attaches a Wi-Fi device after seeing the same announcement, the lookup is retried briefly, and a goodbye or rescan cancels it.Fixes found along the way
These apply to every platform:
Installation SucceededorInstallation complete. INFO logs can be hidden byRUST_LOG, and a success-looking line can precede a later failure.PairManagerstate guarded against races. The server sends an explicitPairing Succeeded!/Pairing Failed!, so the pair page no longer guesses from the output. The page also handles timeouts and lost connections, and clears the PIN.CheckAfcServiceshadowederr, so a usbmuxd restart that is not supported (it returnednil) counted as a successful recheck. Restarting usbmuxd now returns an explicit error outside Linux.TestSaveUpdateSettingsBlankRemovesTokenflaky on master.macos-latestjob, runsgo test ./..., compiles both macOS architectures and usesnpm ci.Not in this PR
plumesign, andrelease.ymladdsdarwin/amd64,darwin/arm64to its xgo targets. macOS users could then download a release instead of building from source. If this direction works for you, I can follow up with a PR to your fork that adds the macOSplumesignbuild to its release.Validation
go test ./..., the race detector oninternal/manager,internal/serviceandinternal/exec,go vet, golangci-lint (0 issues) and the frontend tests pass.doc/macos.mdon a clean checkout builds the web UI, the service and the signing engine, and the service starts, finds the adjacentplumesignwithoutPATHand serves the web UI.plumesign device-inforeaches it through the macOS usbmuxd.Related to #96.