Repository navigation
fix(discovery): redact remote pairing auth tags from logs - #205
Merged
bitxeno merged 5 commits intoOct 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Discovery debug output included the
authTagvalue from Apple TV_remotepairing._tcpadvertisements. The follow-upplumesign check find-pairingcommand logged the same value as an argument. Pairing authentication material should not appear in logs.Changes
authTagin a copy of the parsed TXT metadata, without modifying the data passed to pairing.Cmd.WithSecretfacility to mask the--auth-tagargument in debug command output.Scope
This addresses a confirmed logging disclosure found during investigation of #202. It does not claim to fix the container crash in #202, which still needs a captured exit status or crash trace before a root-cause patch can be justified.
Validation
masterat603205d761f47863087ac049e04e33d480ef2b98.go test ./internal/manager -count=1 -timeout=180s: passed.go vet ./internal/manager: passed.