Skip to content

fix(discovery): redact remote pairing auth tags from logs - #205

Merged
bitxeno merged 5 commits into
bitxeno:masterfrom
YellowNest:fix/avahi-redact-pairing-auth-tag
Oct 11, 2026
Merged

bitxeno merged 5 commits into
bitxeno:masterfrom
YellowNest:fix/avahi-redact-pairing-auth-tag

Conversation

@YellowNest

@YellowNest YellowNest commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Discovery debug output included the authTag value from Apple TV _remotepairing._tcp advertisements. The follow-up plumesign check find-pairing command logged the same value as an argument. Pairing authentication material should not appear in logs.

Changes

  • Centralize Avahi service-event logging, replacing six repeated log call sites.
  • Redact authTag in a copy of the parsed TXT metadata, without modifying the data passed to pairing.
  • Use the existing Cmd.WithSecret facility to mask the --auth-tag argument in debug command output.
  • Add Linux regression coverage for both redaction and preservation of original pairing data, including TXT records without an auth tag.

Scope

This addresses a confirmed logging disclosure found during investigation of #202. It does not claim to fix the container crash in #202, which still needs a captured exit status or crash trace before a root-cause patch can be justified.

Validation

  • Based on upstream master at 603205d761f47863087ac049e04e33d480ef2b98.
  • Focused redaction regression tests with Go race detector: passed.
  • Complete go test ./internal/manager -count=1 -timeout=180s: passed.
  • go vet ./internal/manager: passed.
  • Normal frontend/build/lint workflow: passed on the three-file code change.
  • Verification workflow run (temporary test workflow removed from the final PR diff).
  • Final PR diff contains only three manager files.

@YellowNest
YellowNest marked this pull request as ready for review October 10, 2026 17:46
@bitxeno
bitxeno merged commit 7adec03 into bitxeno:master Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址