Skip to content

fix(web): avoid logging install credentials and pairing PINs - #201

Merged
bitxeno merged 1 commit into
bitxeno:masterfrom
YellowNest:fix/websocket-sensitive-payload-logging
Oct 9, 2026
Merged

bitxeno merged 1 commit into
bitxeno:masterfrom
YellowNest:fix/websocket-sensitive-payload-logging

Conversation

@YellowNest

Copy link
Copy Markdown
Contributor

Problem

Both WebSocket send helpers write the complete serialized outgoing message to the browser console:

  • The install page's message includes the Apple ID password field.
  • The pairing page's message includes the six-digit Apple TV PIN.

These values do not need to be logged for WebSocket transport or troubleshooting, and the logs remain accessible in browser developer tools.

Changes

  • Remove full outgoing-payload logging in the install and pairing pages.
  • Leave WebSocket serialization and transmission unchanged.
  • Add regression tests that check the password and PIN are delivered to the WebSocket but are absent from captured browser-console output.

Verification

  • Reviewed both outgoing WebSocket call paths and their existing transport implementations.
  • Branch contains one commit and changes only two Vue pages and two Node test files.
  • The new tests exercise the actual component methods with mocked WebSockets rather than relying on source-text assertions.

No changes to signing, pairing protocols, credentials storage, or logging on the server.

The install and pairing pages dumped complete outgoing WebSocket messages
to the console, including Apple ID passwords and pairing PINs. Remove
these payload logs without changing what is sent to the server.

Add regression coverage asserting both secrets reach their intended
WebSocket endpoint but never appear in browser console logging.
@bitxeno
bitxeno merged commit 0cb114d into bitxeno:master Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址