Repository navigation
fix(web): avoid logging install credentials and pairing PINs - #201
Merged
bitxeno merged 1 commit intoOct 9, 2026
Merged
Conversation
The install and pairing pages dumped complete outgoing WebSocket messages to the console, including Apple ID passwords and pairing PINs. Remove these payload logs without changing what is sent to the server. Add regression coverage asserting both secrets reach their intended WebSocket endpoint but never appear in browser console logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both WebSocket send helpers write the complete serialized outgoing message to the browser console:
passwordfield.These values do not need to be logged for WebSocket transport or troubleshooting, and the logs remain accessible in browser developer tools.
Changes
Verification
No changes to signing, pairing protocols, credentials storage, or logging on the server.