Repository navigation
fix(task): preserve overlapping notification batches - #197
Merged
bitxeno merged 1 commit intoOct 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Batch notification tracking keeps only one global
currentBatch.If another
StartInstallAppscall queues at least one distinct app while the current batch is still in flight, the later call replacescurrentBatch. The install queue itself is FIFO and processed by a single consumer, so the older batch still finishes first — buttrackBatchProgressthen sees a differentBatchIDand drops that progress entirely.The existing guard already preserves the current batch when a later call queues zero apps. It does not cover the same overlap when the later call actually queues work.
Fix
Keep later batch metadata in a FIFO
pendingBatchesqueue while a batch is active.When the current batch completes:
currentBatchonly when no batches remain.Calls that queue zero apps still leave the existing batch state untouched.
Regression coverage
TestStartInstallAppsKeepsDistinctBatchesInOrderreproduces the overlap with two distinct batches.On upstream
6270e7f, it fails with:With this change:
passes, and the regression test also passes repeatedly with
-count=10.Scope
Two files, one commit, no API/UI/database changes.