|
| 1 | +package service |
| 2 | + |
| 3 | +import ( |
| 4 | + "errors" |
| 5 | + "fmt" |
| 6 | + "os" |
| 7 | + "path/filepath" |
| 8 | + "testing" |
| 9 | + |
| 10 | + "github.com/bitxeno/atvloadly/internal/app" |
| 11 | + "github.com/bitxeno/atvloadly/internal/db" |
| 12 | + "github.com/bitxeno/atvloadly/internal/model" |
| 13 | +) |
| 14 | + |
| 15 | +func TestDeleteAppOnlyRemovesOwnedDirectory(t *testing.T) { |
| 16 | + for _, test := range []struct { |
| 17 | + name string |
| 18 | + path string |
| 19 | + }{ |
| 20 | + {name: "external path", path: "external"}, |
| 21 | + {name: "staged upload", path: "upload"}, |
| 22 | + {name: "empty path"}, |
| 23 | + {name: "another app path", path: "other-app"}, |
| 24 | + } { |
| 25 | + t.Run(test.name, func(t *testing.T) { |
| 26 | + setupTestDB(t) |
| 27 | + dataDir := app.Config.Server.DataDir |
| 28 | + |
| 29 | + installed := &model.InstalledApp{IpaName: "To remove"} |
| 30 | + if err := db.Store().Create(installed).Error; err != nil { |
| 31 | + t.Fatal(err) |
| 32 | + } |
| 33 | + |
| 34 | + ownedDir := filepath.Join(dataDir, "ipa", fmt.Sprintf("%d", installed.ID)) |
| 35 | + ownedFile := writeTestFile(t, filepath.Join(ownedDir, "app.ipa")) |
| 36 | + |
| 37 | + var unrelatedFile, storedPath string |
| 38 | + switch test.path { |
| 39 | + case "external": |
| 40 | + unrelatedFile = writeTestFile(t, filepath.Join(t.TempDir(), "unrelated", "keep.ipa")) |
| 41 | + storedPath = unrelatedFile |
| 42 | + case "upload": |
| 43 | + storedPath = writeTestFile(t, filepath.Join(dataDir, "tmp", "staged.ipa")) |
| 44 | + unrelatedFile = writeTestFile(t, filepath.Join(dataDir, "tmp", "keep.ipa")) |
| 45 | + case "other-app": |
| 46 | + other := &model.InstalledApp{IpaName: "Keep"} |
| 47 | + if err := db.Store().Create(other).Error; err != nil { |
| 48 | + t.Fatal(err) |
| 49 | + } |
| 50 | + unrelatedFile = writeTestFile(t, filepath.Join(dataDir, "ipa", fmt.Sprintf("%d", other.ID), "app.ipa")) |
| 51 | + storedPath = unrelatedFile |
| 52 | + } |
| 53 | + if err := db.Store().Model(installed).Update("ipa_path", storedPath).Error; err != nil { |
| 54 | + t.Fatal(err) |
| 55 | + } |
| 56 | + |
| 57 | + removed, err := DeleteApp(installed.ID) |
| 58 | + if err != nil || !removed { |
| 59 | + t.Fatalf("DeleteApp = %t, %v", removed, err) |
| 60 | + } |
| 61 | + if _, err := GetApp(installed.ID); err == nil { |
| 62 | + t.Fatal("app record still exists") |
| 63 | + } |
| 64 | + if _, err := os.Stat(ownedFile); !errors.Is(err, os.ErrNotExist) { |
| 65 | + t.Fatalf("own app directory was not removed: %v", err) |
| 66 | + } |
| 67 | + if unrelatedFile != "" { |
| 68 | + if _, err := os.Stat(unrelatedFile); err != nil { |
| 69 | + t.Fatalf("another file was removed: %v", err) |
| 70 | + } |
| 71 | + } |
| 72 | + }) |
| 73 | + } |
| 74 | +} |
| 75 | + |
| 76 | +func TestDeleteAppWithoutStorageRootKeepsRecord(t *testing.T) { |
| 77 | + for _, tc := range []struct { |
| 78 | + name string |
| 79 | + nilConfig bool |
| 80 | + }{ |
| 81 | + {name: "nil config", nilConfig: true}, |
| 82 | + {name: "empty data directory"}, |
| 83 | + } { |
| 84 | + t.Run(tc.name, func(t *testing.T) { |
| 85 | + setupTestDB(t) |
| 86 | + dataDir := app.Config.Server.DataDir |
| 87 | + |
| 88 | + record := &model.InstalledApp{IpaName: "Keep"} |
| 89 | + if err := db.Store().Create(record).Error; err != nil { |
| 90 | + t.Fatal(err) |
| 91 | + } |
| 92 | + ownedFile := writeTestFile(t, filepath.Join(dataDir, "ipa", fmt.Sprintf("%d", record.ID), "app.ipa")) |
| 93 | + |
| 94 | + if tc.nilConfig { |
| 95 | + app.Config = nil |
| 96 | + } else { |
| 97 | + app.Config.Server.DataDir = "" |
| 98 | + } |
| 99 | + deleted, err := DeleteApp(record.ID) |
| 100 | + if err == nil || deleted { |
| 101 | + t.Fatalf("DeleteApp with missing storage root = %t, %v; want error without deletion", deleted, err) |
| 102 | + } |
| 103 | + if _, err := GetApp(record.ID); err != nil { |
| 104 | + t.Fatalf("app record was deleted: %v", err) |
| 105 | + } |
| 106 | + if _, err := os.Stat(ownedFile); err != nil { |
| 107 | + t.Fatalf("app files were altered: %v", err) |
| 108 | + } |
| 109 | + }) |
| 110 | + } |
| 111 | +} |
0 commit comments