Skip to content
This repository was archived by the owner on Jun 26, 2023. It is now read-only.

Upgrade k8s.io/apimachinery to v0.19.0-beta.2 to be able to handle big YAML file - #24

Merged
dragon3 merged 1 commit into
babarot:masterfrom
dragon3:upgrade-k8s.io-apimachinery-to-v0.19.0-beta.2
Jun 17, 2020
Merged

dragon3 merged 1 commit into
babarot:masterfrom
dragon3:upgrade-k8s.io-apimachinery-to-v0.19.0-beta.2

Conversation

@dragon3

@dragon3 dragon3 commented Jun 17, 2020

Copy link
Copy Markdown
Collaborator

WHAT

This pull request upgrades k8s.io/apimachinery to v0.19.0-beta.2 to be able to handle big YAML file.

The stein uses k8s.io/apimachinery/pkg/util/yaml package to decode YAML file, but it has a similar issue to #23.

I found kubernetes/apimachinery@822d4d0 to fix the issue.

Since the latest stable version k8s.io/apimachinery@v0.18.3 doesn't have the change, this pull request uses v0.19.0-beta.2.

This pull request also changes Test_handleYAML_LineTooLong accordingly.

WHY

To fix the following error If YAML is very big (over: bufio.MaxScanTokenSize):

bufio.Scanner: token too long

@dragon3
dragon3 requested review from babarot and dtan4 June 17, 2020 08:04
@dragon3 dragon3 self-assigned this Jun 17, 2020

@dtan4 dtan4 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dragon3

dragon3 commented Jun 17, 2020

Copy link
Copy Markdown
Collaborator Author

Thank you for the review! I'm going to merge it and release v0.3.4 💪

@dragon3
dragon3 merged commit ebf9492 into babarot:master Jun 17, 2020
@dragon3
dragon3 deleted the upgrade-k8s.io-apimachinery-to-v0.19.0-beta.2 branch June 17, 2020 23:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址