This repository was archived by the owner on Jun 26, 2023. It is now read-only.
Repository navigation
Upgrade k8s.io/apimachinery to v0.19.0-beta.2 to be able to handle big YAML file - #24
Merged
dragon3 merged 1 commit intoJun 17, 2020
Conversation
Collaborator
Author
|
Thank you for the review! I'm going to merge it and release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
This pull request upgrades
k8s.io/apimachinerytov0.19.0-beta.2to be able to handle big YAML file.The stein uses
k8s.io/apimachinery/pkg/util/yamlpackage to decode YAML file, but it has a similar issue to #23.I found kubernetes/apimachinery@822d4d0 to fix the issue.
Since the latest stable version
k8s.io/apimachinery@v0.18.3doesn't have the change, this pull request usesv0.19.0-beta.2.This pull request also changes
Test_handleYAML_LineTooLongaccordingly.WHY
To fix the following error If YAML is very big (over:
bufio.MaxScanTokenSize):