Repository navigation
Remove metadata transfer from Data Transfer 00b commands - #2145
Merged
Merged
Conversation
Per the NVMe spec, no-data commands (Data Transfer 00b) such as Write Zeroes, Write Uncorrectable, and Verify do not require a data or metadata transfer. Previously, cmd->metadata and cmd->metadata_len were still set for these commands whenever the namespace had metadata configured, regardless of the command's data transfer type. Restrict metadata assignment to commands that actually transfer data (read, write, compare, zns append) so that no-data commands no longer carry a stale metadata pointer/length. Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the NVMe spec, no-data commands (Data Transfer 00b) such as Write Zeroes, Write Uncorrectable, and Verify do not require a data or metadata transfer. Previously, cmd->metadata and cmd->metadata_len were still set for these commands whenever the namespace had metadata configured, regardless of the command's data transfer type. Restrict metadata assignment to commands that actually transfer data (read, write, compare, zns append) so that no-data commands no longer carry a stale metadata pointer/length.