Repository navigation
fio: fixes for io_submit_mode=offload stability - #2058
Merged
Merged
Conversation
The thinktime_blocks_counter is only initialized and updated at the thread level. However, reset_all_stats() is also called for io_workers when offload mode is enabled. Add a check to ensure thinktime_blocks_counter is allocated before attempting to sum its values. This prevents a null pointer dereference and subsequent crash in offload workers. Signed-off-by: Tomas Winkler <tomas.winkler@sandisk.com>
Contributor
Author
|
Any comments on this PR? |
axboe
reviewed
Feb 23, 2026
Owner
|
Looks fine, just a style issue highlighted. |
In the ramp state is managed by a helper thread calling ramp_period_check(). This helper thread advances the state for the parent job thread_data, but when runnign io_submit_mode=offload it does not have access to the private thread data of the individual offload worker threads. As a result, worker threads calling ramp_period_over() may remain stuck in an old ramp state, never observing the transition to RAMP_FINISHING or RAMP_DONE. This prevents the workers from properly transitioning to the main workload and can cause fio to hang indefinitely instead of reaching runtime completion. Propagate the RAMP_FINISHING state from the parent thread_data to the worker td within ramp_period_over(). This ensures that workers stay in sync with the state machine managed by the helper thread. Signed-off-by: Chana Zaks <chana.zaks@sandisk.com> Signed-off-by: Tomas Winkler <tomas.winkler@sandisk.com>
tomas-winkler-sndk
force-pushed
the
offload_stability
branch
from
February 23, 2026 16:39
1e38c4e to
2349972
Compare
Contributor
Author
|
Looks like the CI has failed on a network issue, not related to the code change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Workqueue Stall: Propagates RAMP_FINISHING state from the parent thread to offload workers. This prevents workers from getting stuck in the ramp phase and hanging the process.
Fix Null Pointer Crash: Adds a check for thinktime_blocks_counter in reset_all_stats(). This prevents a crash when resetting statistics in offload mode where workers lack local counter allocation.