Repository navigation
RBD Encryption Support - #2039
Merged
Merged
Conversation
sitsofe
reviewed
Jan 16, 2026
sitsofe
reviewed
Jan 16, 2026
sitsofe
left a comment
Collaborator
There was a problem hiding this comment.
- I'm fine with your choice not to auto-format the image (but I'm not benchmarking Ceph so perhaps I'm not the target audience)
- Please squash these commits into one - this can be seen as being atomic and can go in all in one go
- You may want to move some of the PR info into the commit message
Greenpepper15
force-pushed
the
rbd-encryption-support
branch
2 times, most recently
from
January 19, 2026 05:36
ffb7ad2 to
870d6cf
Compare
Author
|
Cool all tests passed. |
axboe
reviewed
Jan 20, 2026
Owner
|
@Greenpepper15 Just that minor nit, if you fix it up and amend the commit and force push it, I can pick it up. Rest looks fine to me. |
Currently, the rbd engine can only attach to unencrypted images. This prevents users from benchmarking the performance impact of librbd's client-side encryption features. This patch adds two new options, 'rbd_encryption_format' and 'rbd_encryption_passphrase', allowing fio to perform encryption/decryption IO with librbd before starting I/O. Signed-off-by: David Mohren <david.mohren@clyso.com>
Greenpepper15
force-pushed
the
rbd-encryption-support
branch
from
January 20, 2026 19:44
870d6cf to
067ffa4
Compare
Owner
|
Pulled with a fixup added on top, github doesn't really render things properly and you had various cases of trailing whitespace or incorrect usage of tabs vs spaces. |
Author
|
Thanks for the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for testing Ceph
librbdclient-side encryption (AES-XTS) by allowing fio to load LUKS keys for an existing image with librbd. After the loading operation any IO to the rbd image will be encrypted/decrypted.See the Ceph documentation for this feature: https://docs.ceph.com/en/reef/rbd/rbd-encryption/
Motivation
librbdhas supported encryption/decryption since Ceph Pacific (16.2.z). However, the fio rbd engine currently lacks the hooks to load encryption context. This prevents users from benchmarking the crypto overhead of this librbd feature.Implementation Details
configureconfiguration to detect if the linkedlibrbdsupportsrbd_encryption_load.rbd_encryption_format: (luks1, luks2)rbd_encryption_passphrase: The key/passphrase to unlock the image.rbd_encryption_load()during the connection phase to load encryption context.Notes on Design
rbd_encryption_format. It is assumed the user has already provisioned and formatted the image using the Ceph CLI (rbd encryption format ...). This avoids accidental data destruction or re-formatting overhead during benchmark runtime.CONFIG_RBD_ENCRYPTION. If fio is built against an older Ceph version (pre-Pacific), the options are unavailable, and the engine behaves as before.Example Job File
And please review the documentation I wrote. I am unsure if the phrasing and syntax I used is consistent with the rest of the documentation.