Skip to content

write_hist_log: do not require ZLIB for non-server instances - #2033

Merged
axboe merged 1 commit into
axboe:masterfrom
alex310110:master
Dec 29, 2025
Merged

axboe merged 1 commit into
axboe:masterfrom
alex310110:master

Conversation

@alex310110

Copy link
Copy Markdown
Contributor

write_hist_log: do not require ZLIB for non-server instances

Since td->client_type is always non-zero (CLI is 1, GUI is 2), the check
if (td->client_type) in init.c always triggers, causing --write_hist_log
to be unusable when ZLIB is not configured for standalone runs.
By checking if the fio instance is_backend, ZLIB availability will be
checked for fio running as server in server/client mode, and the check
will be passed for fio running in standalone mode.

Fixes #1996

Signed-off-by: Alex Qiu xqiu@google.com

Since `td->client_type` is always non-zero (CLI is 1, GUI is 2), the check
`if (td->client_type)` in `init.c` always triggers, causing --write_hist_log
to be unusable when ZLIB is not configured for standalone runs.
By checking if the fio instance `is_backend`, ZLIB availability will be
checked for fio running as server in server/client mode, and the check
will be passed for fio running in standalone mode.
@alex310110

alex310110 commented Dec 29, 2025 •

Copy link
Copy Markdown
Contributor Author

I manually tested it: In standalone mode, we can now get latency histogram logs correctly; in server/client mode, the server will produce this error message and get streamed to client stdout.

@axboe
axboe merged commit e12461d into axboe:master Dec 29, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enabling --write_hist_log=foo fails if ZLIB not enabled

2 participants

⌂ 换网址