Repository navigation
io_uring: don't segfault if pi_chk isn't specified - #2030
Conversation
If fio is run with md_per_io_size but no pi_chk argument, fio_ioring_io_u_init() passes NULL to strstr(), which segfaults. Use the struct ioring_options prchk flags instead, which have already been parsed from pi_chk in parse_prchk_flags(). Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
|
Can you share the job that triggers this issue? I think the change is good, actually, but am having trouble understanding how the issue occurs.
It might be reasonable also to just change the default for |
|
The segfault can be reproduced with
I'm not sure what you mean. |
|
Ok I see now. Thanks for the fix. I could not trigger the issue with |
If
fiois run withmd_per_io_sizebut nopi_chkargument,fio_ioring_io_u_init()passesNULLtostrstr(), which segfaults. Use thestruct ioring_optionsprchkflags instead, which have already been parsed frompi_chkinparse_prchk_flags().