Skip to content

engines/io_uring: validate PI on read - #1992

Merged
axboe merged 1 commit into
axboe:masterfrom
stanleyzhang9:fix/io_uring-pi-validate
Oct 1, 2025
Merged

axboe merged 1 commit into
axboe:masterfrom
stanleyzhang9:fix/io_uring-pi-validate

Conversation

@stanleyzhang9

@stanleyzhang9 stanleyzhang9 commented Oct 1, 2025 •

Copy link
Copy Markdown
Contributor

Currently, the call to validate metadata at the end of fio_ioring_event is unreachable.
Move the call within the success path, and clean up indentation by removing a redundant if statement.

@vincentkfu

Copy link
Copy Markdown
Collaborator

Thank you for catching this. pi_act is actually checked later on, so it is not necessary to have it here.
We should have some negative error cases in t/io_uring_pi.py but I could not come up with a way implement them.

Currently, the call to validate metadata at the end of fio_ioring_event is
unreachable. Move the call within the success path. Clean up indentation
by removing a redundant if statement.

Signed-off-by: Stanley Zhang <stazhang@purestorage.com>
@stanleyzhang9
stanleyzhang9 force-pushed the fix/io_uring-pi-validate branch from 1cb4e9c to 72fb5b5 Compare October 1, 2025 17:45
@stanleyzhang9

Copy link
Copy Markdown
Contributor Author

Removed the unnecessary pi_act check as you pointed out.

@axboe
axboe merged commit 97a91b6 into axboe:master Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址