Repository navigation
fio: fix formats under MIPS64/PPC - #1779
Conversation
|
Please ensure the commit message is properly formatted. Break lines at 72-74 chars, and include a signed-off-by line. Just see other commits in the repo if in doubt. |
| #ifndef FIO_NVME_H | ||
| #define FIO_NVME_H | ||
|
|
||
| #define __SANE_USERSPACE_TYPES__ |
There was a problem hiding this comment.
This should probably go in the Makefile for mips64, not in this specific location?
|
Hello @neheb: Would you be able to make the changes that Jens suggested? |
|
not sure how to go about that. |
|
Just do |
|
It's not that. I don't see where platform specific defines are located or should be. |
|
There are none, but it'd be easy to add in the top level Makefile for when fio is being compiled with mips64 as the target. You could also probably just as well add it in Edit: and the ppc counterparts too. |
|
Did that. |
|
Still missing a signed-off-by, see any other commit in the tree. |
|
Is this fine to set for 32-bit mips and ppc too? Presumably yes and it will only impact the 64-bit variants? Since you're going to be amending the commit message anyway, maybe add a bit more of an explanation of why this is needed. |
|
And finally, does this need an ifndef around it? In case of nested included. |
|
added ifndef. and yes it's no-op on 32-bit. |
|
I'll mention this one again: Still missing a signed-off-by, see any other commit in the tree. When that's done, this should be good to go. Also see the other previous comment #1779 (comment) |
__SANE_USERSPACE_TYPES__ needs to be defined to get consistent formats on all platforms. It mostly affects 64-bit architectures (no op on 32 bit) with long long vs long. Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
done. |
SANE_USERSPACE_TYPES needs to be defined to get consistent formats on all platforms.