Skip to content

fio: fix formats under MIPS64/PPC - #1779

Merged
axboe merged 1 commit into
axboe:masterfrom
neheb:patch-1
Aug 27, 2025
Merged

axboe merged 1 commit into
axboe:masterfrom
neheb:patch-1

Conversation

@neheb

@neheb neheb commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

SANE_USERSPACE_TYPES needs to be defined to get consistent formats on all platforms.

@axboe

axboe commented Jun 28, 2024

Copy link
Copy Markdown
Owner

Please ensure the commit message is properly formatted. Break lines at 72-74 chars, and include a signed-off-by line. Just see other commits in the repo if in doubt.

Comment thread engines/nvme.h Outdated
#ifndef FIO_NVME_H
#define FIO_NVME_H

#define __SANE_USERSPACE_TYPES__

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go in the Makefile for mips64, not in this specific location?

@sitsofe

sitsofe commented Aug 23, 2025

Copy link
Copy Markdown
Collaborator

Hello @neheb:

Would you be able to make the changes that Jens suggested?

@sitsofe sitsofe added the needreporterinfo Waiting on information from the issue reporter label Aug 23, 2025
@neheb

neheb commented Aug 23, 2025

Copy link
Copy Markdown
Contributor Author

not sure how to go about that.

@axboe

axboe commented Aug 23, 2025

Copy link
Copy Markdown
Owner

Just do git --amend while on your branch with that commit, and edit the commit message. Then git push --force afterwards to overwrite the commit.

@neheb

neheb commented Aug 23, 2025

Copy link
Copy Markdown
Contributor Author

It's not that. I don't see where platform specific defines are located or should be.

@axboe

axboe commented Aug 24, 2025 •

Copy link
Copy Markdown
Owner

There are none, but it'd be easy to add in the top level Makefile for when fio is being compiled with mips64 as the target. You could also probably just as well add it in arch/arch-mips.h as anything would end up including that. Probably the better choice.

Edit: and the ppc counterparts too.

@neheb

neheb commented Aug 24, 2025

Copy link
Copy Markdown
Contributor Author

Did that.

@axboe

axboe commented Aug 24, 2025

Copy link
Copy Markdown
Owner

Still missing a signed-off-by, see any other commit in the tree.

@axboe

axboe commented Aug 24, 2025

Copy link
Copy Markdown
Owner

Is this fine to set for 32-bit mips and ppc too? Presumably yes and it will only impact the 64-bit variants? Since you're going to be amending the commit message anyway, maybe add a bit more of an explanation of why this is needed.

@axboe

axboe commented Aug 24, 2025

Copy link
Copy Markdown
Owner

And finally, does this need an ifndef around it? In case of nested included.

@neheb

neheb commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

added ifndef. and yes it's no-op on 32-bit.

@axboe

axboe commented Aug 26, 2025

Copy link
Copy Markdown
Owner

I'll mention this one again: Still missing a signed-off-by, see any other commit in the tree. When that's done, this should be good to go. Also see the other previous comment #1779 (comment)

__SANE_USERSPACE_TYPES__ needs to be defined to get consistent formats on all platforms.

It mostly affects 64-bit architectures (no op on 32 bit) with long long
vs long.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb

neheb commented Aug 27, 2025

Copy link
Copy Markdown
Contributor Author

done.

@axboe
axboe merged commit d6acda3 into axboe:master Aug 27, 2025
@neheb
neheb deleted the patch-1 branch August 27, 2025 04:01
@sitsofe sitsofe removed the needreporterinfo Waiting on information from the issue reporter label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址