Repository navigation
fix(codegen): drop redundant alias from node:stream Readable type import - #8402
Merged
Merged
Conversation
Alan4506
force-pushed
the
Alan4506/fix/httpchecksum-readable-import
branch
from
November 4, 2026 17:17
6a2c8ff to
8383033
Compare
Alan4506
marked this pull request as ready for review
November 4, 2026 17:42
smilkuri
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
JS-7243
Description
Codegen emits
import type { Readable as Readable } from "node:stream"for clients with@httpChecksum, which fails oxlintno-useless-rename. Drop the redundant alias and remove the S3-only lint override that was masking it.Testing
Regenerated clients, ran lint and build locally.
Checklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.