Skip to content

fix(codegen): drop redundant alias from node:stream Readable type import - #8402

Merged
Alan4506 merged 1 commit into
mainfrom
Alan4506/fix/httpchecksum-readable-import
Nov 4, 2026
Merged

Alan4506 merged 1 commit into
mainfrom
Alan4506/fix/httpchecksum-readable-import

Conversation

@Alan4506

@Alan4506 Alan4506 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Issue

JS-7243

Description

Codegen emits import type { Readable as Readable } from "node:stream" for clients with @httpChecksum, which fails oxlint no-useless-rename. Drop the redundant alias and remove the S3-only lint override that was masking it.

Testing

Regenerated clients, ran lint and build locally.

Checklist

  • If the PR is a feature, add integration tests (*.integ.spec.ts) or E2E tests.
    • It's not a feature.
  • My E2E tests are resilient to concurrent i/o.
    • I didn't write any E2E tests.
  • I added access level annotations e.g. @public, @internal tags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.
    • I didn't add any public functions.
  • Streams - how do they work?? My WebStream readers/locks are properly lifecycled. Node.js stream backpressure is handled. Error handling.
    • No streams here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Alan4506
Alan4506 force-pushed the Alan4506/fix/httpchecksum-readable-import branch from 6a2c8ff to 8383033 Compare November 4, 2026 17:17
@Alan4506
Alan4506 marked this pull request as ready for review November 4, 2026 17:42
@Alan4506
Alan4506 requested a review from a team as a code owner November 4, 2026 17:42
@Alan4506
Alan4506 merged commit 4e5ce5a into main Nov 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址