Repository navigation
feat(codegen): add Smithy RPCv2 JSON protocol - #8386
Merged
Merged
Conversation
kingaly111
marked this pull request as ready for review
October 27, 2026 18:16
kuhe
requested changes
Oct 27, 2026
kuhe
left a comment
Contributor
There was a problem hiding this comment.
before we make this available in AWS SDK, the SmithyRpcV2JsonProtocol needs a local extension class which implements AwsQueryCompatible
kuhe
approved these changes
Oct 28, 2026
Register Rpcv2JsonTrait and an AwsSmithyRpcV2Json generator that extends the smithy-typescript SmithyRpcV2Json generator, with AWSQuery compatibility support mirroring AwsSmithyRpcV2Cbor. RPCv2 JSON is ordered ahead of RPCv2 CBOR, matching the existing JSON-first priority for JavaScript runtimes. Depends on smithy-typescript#2295.
Extend SmithyRpcV2JsonProtocol with awsQueryCompatible support, mirroring AwsSmithyRpcV2CborProtocol: send x-amzn-query-mode when enabled and resolve errors via the x-amzn-query-error header through ProtocolLib. Error members are read with the JSON codec's readObject, as in the base class, since the error body is already parsed JSON. Export it from @aws-sdk/core/protocols and @aws-sdk/config/protocol.
kingaly111
force-pushed
the
kingaly/feat/rpcv2-json-protocol
branch
from
October 28, 2026 20:50
4610479 to
8ed8fd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register Rpcv2JsonTrait and an AwsSmithyRpcV2Json generator that extends the smithy-typescript SmithyRpcV2Json generator, with AWSQuery compatibility support mirroring AwsSmithyRpcV2Cbor. RPCv2 JSON is ordered ahead of RPCv2 CBOR, matching the existing JSON-first priority for JavaScript runtimes.
Depends on smithy-typescript#2295.
Issue
Issue number, if available, prefixed with "#"
Description
What does this implement/fix? Explain your changes.
Testing
How was this change tested?
Checklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.