Repository navigation
Parse and validate variant metadata - #22512
Merged
Merged
Conversation
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 13, 2026 12:51
aa435c3 to
f1ef4e4
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 13, 2026 13:08
f1ef4e4 to
c349c78
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 13, 2026 13:16
c349c78 to
c5ddece
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 13, 2026 13:36
c5ddece to
4d60ede
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 13, 2026 13:43
4d60ede to
96a4f87
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 13, 2026 15:59
96a4f87 to
4703454
Compare
31 of 50 tasks
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 14, 2026 09:06
4703454 to
0077c86
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 14, 2026 09:33
0077c86 to
bcc0b1e
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 14, 2026 09:46
bcc0b1e to
8d359d0
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 18, 2026 10:38
ca82c70 to
a9bff7d
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 18, 2026 12:51
a9bff7d to
5d89aa1
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 18, 2026 15:52
5f92508 to
2449eef
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 19, 2026 10:21
2449eef to
5add82f
Compare
konstin
force-pushed
the
konsti/wheel-variant-metadata
branch
from
October 19, 2026 11:42
5add82f to
b9e5805
Compare
uv test inventory changesThis PR changes the tests when compared with the
|
zsol
approved these changes
Oct 20, 2026
| #[serde(rename_all = "kebab-case", try_from = "VariantsJsonWire")] | ||
| pub struct VariantsJsonContent { | ||
| #[serde(rename = "$schema")] | ||
| schema: String, |
Member
There was a problem hiding this comment.
I wonder if it'd be worth having a separate type for this
Member
Author
There was a problem hiding this comment.
What kind of type do you have in mind?
1 task
This was referenced Oct 24, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
variants.jsonparsing following PEP 825. Invalid variant metadata is treat like other invalid package metadata, backtracking on the version (instead of failing). The parsed data isn't used yet.