Repository navigation
Conversation
Requirements file options were matched as prefixes, so `--no-indexx` was parsed as `--no-index` plus requirement `x`, while `--prefoo` was silently ignored as `--pre`. Require a token boundary after recognized option names.
Merging this PR will improve performance by ×9.3
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | unzip_wheel_many_files |
371 ms | 12.2 ms | ×30 |
| ⚡ | WallTime | install_wheel_many_files |
385 ms | 13.4 ms | ×29 |
| ⚡ | WallTime | prepare_wheel_many_files |
383.4 ms | 14.8 ms | ×26 |
| ⚡ | WallTime | unpack_sdist_many_files |
317.2 ms | 36 ms | ×8.8 |
| ⚡ | WallTime | resolve_warm_jupyter_universal |
87.6 ms | 11.6 ms | ×7.5 |
| ⚡ | WallTime | resolve_warm_jupyter |
17.4 ms | 2.4 ms | ×7.1 |
| ⚡ | WallTime | discover_workspace_from_all_members_with_excludes |
52.7 ms | 8 ms | ×6.6 |
| ⚡ | WallTime | discover_workspace_from_all_members |
50.5 ms | 7.7 ms | ×6.5 |
| ⚡ | WallTime | run_python_version_synthetic_workspace |
268.4 ms | 42 ms | ×6.4 |
| ⚡ | WallTime | resolve_warm_airflow |
233.2 ms | 41.6 ms | ×5.6 |
| ⚡ | WallTime | hash_sha256 |
1,165.6 µs | 403.6 µs | ×2.9 |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing zb/reject-malformed-requirement-options (91bf0a7) with main (b7c8c62)2
Footnotes
-
35 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(17cdcc3) during the generation of this report, so b7c8c62 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
Promoted to #22317. |
Malformed options such as
--no-indexx,--prefoo, and--trusted-hostilecan be partially parsed or silently ignored. Require token boundaries after recognized option names.