Repository navigation
ci: pin golangci-lint tooling and checks - #150
Merged
Merged
Conversation
- Align lint rules and formatting with the signet configuration - Pin isolated Go tooling and use the same Make targets in CI - Resolve existing lint findings while preserving plugin behavior
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues blocking the lint-tooling and CI changes.
No open issues 🎉
What changed in this PR
Standardizes linting for the Telegram plugin with isolated, pinned tooling and shared local and CI commands, while preserving existing build, release, and test targets.
Changes:
- Pins golangci-lint v2.15.0 and its dependencies in a separate tools module.
- Routes formatting and lint checks through Makefile targets used by CI.
- Updates import grouping and gofumpt rules to align with signet’s configuration.
| File | Description |
|---|---|
Makefile |
Uses pinned tooling for formatting and adds lint and tool-download targets. |
go.tools.sum |
Records checksums for tool dependencies. |
go.tools.mod |
Declares the isolated tools module and pins golangci-lint. |
.golangci.yml |
Configures module-specific import grouping and gofumpt rules. |
.github/workflows/testing.yml |
Runs shared Makefile checks and includes tool dependencies in caching. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardize linting on signet's configuration, with the import prefix adapted to this module. Pin golangci-lint v2.15.0 in an isolated
go.tools.mod/go.tools.sum, and run the samemake lintandmake fmt-checkcommands locally and in.github/workflows/testing.yml. Preserve existing build/release targets and test jobs. Apply formatting and the minimal lint fixes needed for the new checks.Plan and classification
drone-plugin.Flow
AI authorship
.github/workflows/testing.yml,.golangci.yml,Makefile,go.tools.mod,go.tools.sum.Verification
Checkout
ci/pin-golangci-lint-tools(verified commita37e858b645d79ce6a321f68afede7eb0797a191), then run commands from the repository root with Go 1.26.10, Git, Make, and actionlint installed. Runmake install-toolsto download the pinned tools; network access to the Go module proxy is required on a cold cache. No production credentials are required.make lintmake fmt-checkgo build ./...go test -count=1 -timeout=5m ./...actionlint .github/workflows/testing.ymlgit diff --staged --checkFormatting failure scenario
lint_rollout_probe.gocontainingpackage mainandfunc lintRolloutProbe( ){ }on separate lines.make fmt-check: expect a nonzero exit and a diff naming that file, with no source modification.make fmt-check: expect exit 0.Execution: Passed; the malformed probe was rejected and removed. Existing code passes formatting checks.
Security, risk, and rollback
No new secrets or external interfaces. Application
go.modandgo.sumremain unchanged. Stricter lint rules can reject future changes; revert this commit to restore the prior tooling. Review.golangci.yml, Makefile/workflow wiring, and source/test lint adjustments; spot-check generated tool dependencies. GitHub-hosted execution has not yet completed locally and should be checked before merge.