Skip to content

fixes source file link generation issue - #79

Merged
nofun97 merged 4 commits into
anz-bank:masterfrom
nofun97:hyperlink-fix
Jun 26, 2020
Merged

nofun97 merged 4 commits into
anz-bank:masterfrom
nofun97:hyperlink-fix

Conversation

@nofun97

@nofun97 nofun97 commented Jun 25, 2020

Copy link
Copy Markdown
Contributor

Before links to source files weren't generated correctly. It tries to link to a memory filesystem that doesn't have the source files. This PR is a quick fix, it will try to generate a link to a github repo instead.

@nofun97
nofun97 requested a review from cuminandpaprika June 25, 2020 07:22

@cuminandpaprika cuminandpaprika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few nitpicks and an overwritten README file.
Could you document the link feature in the Readme btw, just briefly describing what it does and the limitations?

Comment thread README.md Resolved
Comment thread demo/html/FirstDivision/index.html Resolved
Comment thread pkg/catalog/generator.go Resolved
Comment thread pkg/catalog/generator.go Resolved

@cuminandpaprika cuminandpaprika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nofun97
nofun97 merged commit 462aa87 into anz-bank:master Jun 26, 2020
@nofun97
nofun97 deleted the hyperlink-fix branch June 26, 2020 04:41
anzopensource pushed a commit that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址