Skip to content

Endpoint escapes - #69

Merged
nofun97 merged 2 commits into
anz-bank:masterfrom
nofun97:endpoint-esc
Jun 23, 2020
Merged

nofun97 merged 2 commits into
anz-bank:masterfrom
nofun97:endpoint-esc

Conversation

@nofun97

@nofun97 nofun97 commented Jun 23, 2020

Copy link
Copy Markdown
Contributor

Endpoints are now not escaped in titles and hyperlinks in applications indexes work

@nofun97
nofun97 requested a review from cuminandpaprika June 23, 2020 06:51

@cuminandpaprika cuminandpaprika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the formatting of endpoint names works nicely, but the anchor links still seem to be broken

@cuminandpaprika
cuminandpaprika self-requested a review June 23, 2020 07:15

@cuminandpaprika cuminandpaprika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, my mistake all working now!

@nofun97
nofun97 merged commit 57274da into anz-bank:master Jun 23, 2020
@nofun97
nofun97 deleted the endpoint-esc branch June 23, 2020 07:42
ChloePlanet pushed a commit that referenced this pull request Oct 7, 2020
Adds a missing MkdirAll which creates the folders in the path if they do not already exist
Adds error and nil checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址