Skip to content

Dates are being deserialized with kind Local (with potential fix) #75

Open

Description

@crochik

Noticed yesterday that dates were coming back with kind Local.

It is my understanding dates from salesforce are all provided as UTC but because of their format (e.g. 2017-05-30T21:10:25.000+0000) the JsonConvert.DeserializeObject by default will attempt some kind of conversion to Local.

It seems like a simple fix (that worked for me):

In JsonClient.cs wherever the JsonConvert.DeserializeObject<T>(...) is being used to deserialize the response, replace with:

JsonConvert.DeserializeObject<T>(..., new JsonSerializerSettings { DateTimeZoneHandling = DateTimeZoneHandling.Utc })

Activity

  1. changed the title [-]Dates are being deserialized with kind Local.[/-] [+]Dates are being deserialized with kind Local (with potential fix)[/+] on Feb 11, 2025
  2. anthonyreilly commented on Feb 11, 2025

    @anthonyreilly
    Owner

    Are you using DateTime or DateTimeOffset in your model objects? I did a quick test and DateTimeOffset is parsing correctly. I'll see if I can add that change without breaking DateTimeOffset parsing.

  3. crochik commented on Feb 11, 2025

    @crochik
    Author

    hi @anthonyreilly. I actually don't define models and use the ExpandoObject so the JsonConvert will create DateTime properties for Date looking properties.

  4. anthonyreilly commented on Feb 11, 2025

    @anthonyreilly
    Owner

    hi @anthonyreilly. I actually don't define models and use the ExpandoObject so the JsonConvert will create DateTime properties for Date looking properties.

    Thanks, I'm writing some tests now, so I'll include an ExpandoObject case as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址