Skip to content

Proposal: add support to xml:space attribute - #12

Merged
zhengchun merged 2 commits into
antchfx:masterfrom
filariow:master
Jun 15, 2019
Merged

zhengchun merged 2 commits into
antchfx:masterfrom
filariow:master

Conversation

@filariow

Copy link
Copy Markdown
Contributor

I noticed that the OutputXML function was trimming my text entries even if the xml:space attribute was set to preserve.
It is fundamental for my scopes to preserve that spaces so I tried to add the support for this attribute.
I've also used an existing test as template to create new tests for my edits and all seams to work right to me.

With this PR I would like to propose the support for the xml:space attribute.
Hope the implementation is satisfactory.

I would like to take this opportunity to thank you for the good job done with this library.

@coveralls

coveralls commented Jun 13, 2019 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.04%) to 83.416% when pulling 5dec624 on FrancescoIlario:master into e401210 on antchfx:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.6%) to 82.963% when pulling ac52038 on FrancescoIlario:master into e401210 on antchfx:master.

@zhengchun
zhengchun merged commit 5dec624 into antchfx:master Jun 15, 2019
zhengchun added a commit that referenced this pull request Jun 15, 2019
@zhengchun

Copy link
Copy Markdown
Contributor

Merged, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址