Repository navigation
Added updated GDScript lexer. - #842
Merged
Merged
Conversation
Owner
|
Thanks! Would you mind converting this to an XML lexer please? Chroma has deprecated use of Go lexers. You can do this with Also rename this to GDScript4 (or rename the original to GDScript3). As for the conflict, that's fairly straightforward to resolve. If GDScript4 is the most common, give it a higher <analyse single="true" >
<regex pattern="(?m)^\s*#include <" score="0.1" />
<regex pattern="(?m)^\s*#ifn?def " score="0.1" />
</analyse> |
Owner
|
You'll probably need to rename the existing tests to gdscript3. |
alecthomas
approved these changes
Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Godot 4 was released a while ago, and the release changed a lot of things in GDScript. This new lexer is currently capable of processing GDScript files written in 4.0 or later. I renamed the existing GDScript lexer to GDScript3, and gave the new one (now named GDScript) a priority of 0.1. I also added some simple analyzers to differentiate if only a file extension is given.