Skip to content

chore: Realign binary naming & ldflags - #99

Merged
ocean merged 6 commits into
ahoy-cli:masterfrom
ocean:reorganise-makefile
Aug 1, 2022
Merged

ocean merged 6 commits into
ahoy-cli:masterfrom
ocean:reorganise-makefile

Conversation

@ocean

@ocean ocean commented Jul 17, 2022

Copy link
Copy Markdown
Member

Bring binary naming in Makefile in line with previous releases
(i.e. make a bare binary, named with suffixes, not in a tar.gz file).

Use Makefile foreach to reduce repetition.

Make ldflags more similar to Homebrew Go standard ldflags so
binaries downloaded from GH or built with Homebrew are more
closely aligned.

Bring binary naming in Makefile in line with previous releases
(i.e. make a bare binary, named with suffixes, not in a tar.gz file).

Use Makefile foreach to reduce repetition.

Make ldflags more similar to Homebrew Go standard ldflags so
binaries downloaded from GH or built with Homebrew are more
closely aligned.
@ocean
ocean requested a review from AlexSkrypnyk July 17, 2022 11:06
Comment thread .gitignore Resolved
@AlexSkrypnyk

Copy link
Copy Markdown
Collaborator

@ocean
This looks great!

However, I cannot find neither tests for producing these binaries nor direct calls to this command in CI + assertions that they were actually created.

Is it possible for you to add a behat test to run make cross and then asserting that a file with a specific extension was created. It won't be asserting that the file is "runnable", but at least we can be sure that the makefile is setup and working correctly.

thanks

@ocean

ocean commented Jul 25, 2022

Copy link
Copy Markdown
Member Author

Ok @AlexSkrypnyk - I wrote a BATS test which cross compiles the binaries and then checks to see they exist, good idea 👍

@ocean
ocean requested a review from AlexSkrypnyk July 25, 2022 12:08
@ocean
ocean force-pushed the reorganise-makefile branch from c0e5fee to 83481eb Compare July 25, 2022 12:19
Comment thread tests/cross-compile.bats Resolved
@ocean
ocean requested a review from AlexSkrypnyk July 27, 2022 12:47

@AlexSkrypnyk AlexSkrypnyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocean
Please merge at your earliest convenience.

@ocean

ocean commented Aug 1, 2022

Copy link
Copy Markdown
Member Author

You're allowed to merge too if you want @AlexSkrypnyk 😜

@ocean
ocean merged commit 8ae52e3 into ahoy-cli:master Aug 1, 2022
@ocean
ocean deleted the reorganise-makefile branch August 4, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址