Skip to content

Make sure Goreleaser checksums cover all binaries - #190

Merged
ocean merged 2 commits into
ahoy-cli:masterfrom
ocean:fix/checksum-raw-binaries
Sep 3, 2026
Merged

ocean merged 2 commits into
ahoy-cli:masterfrom
ocean:fix/checksum-raw-binaries

Conversation

@ocean

@ocean ocean commented Sep 3, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Release Improvements

    • Checksums are now generated for regular and static raw binary release files.
  • Documentation

    • Updated the Sponsors section.
    • Corrected contributor avatar sizing markup.

The ahoy-bin-* binaries reach the release through release.extra_files,
which bypasses the checksum pipe, so they shipped with no checksums at
all. v3.0.1 lists 20 entries for 30 artifacts: the archives and the
SBOMs, but none of the binaries. The same gap is in v3.0.0, and in
v2.5.0 before the goreleaser rework.

It matters because the raw binaries are what the documented install
one-liner downloads, so the artifacts people actually run were the ones
they could not verify, while the archives nobody installs from were
fully covered.

checksum.extra_files takes the same globs as release.extra_files.
Verified with a full snapshot build: the checksums file goes from 20
entries to 30, covering every non-checksum asset, with no duplicates
between the two globs, and the recorded hashes match the built files.

Claude-Session: https://claude.ai/code/session_01629NFuQxTr678Tdh8AD39d
Signed-off-by: Drew Robinson <drew.robinson@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 5935d563-7bf3-4372-b474-06369d866224

📥 Commits

Reviewing files that changed from the base of the PR and between 86a4fbc and d2b8094.

📒 Files selected for processing (2)
  • .goreleaser.yaml
  • README.md

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The release configuration now generates checksums for regular and static raw binaries. The README updates the Sponsors section and corrects contributor image width attributes.

Changes

Release checksum coverage

Layer / File(s) Summary
Raw binary checksum patterns
.goreleaser.yaml
The checksum configuration now includes regular and static raw binaries uploaded through release.extra_files.

README metadata

Layer / File(s) Summary
Sponsor and contributor metadata
README.md
The Sponsors section adds Teofilo Sibileau and removes DrevOps. Contributor image widths change from 64px; to 64.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to d2b80

Release checksums now cover the intended raw binaries, and the documentation metadata updates are safe. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarises the main change: extending Goreleaser checksum coverage to all binary artefacts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ocean
ocean merged commit 29a6e6f into ahoy-cli:master Sep 3, 2026
13 checks passed
@ocean
ocean deleted the fix/checksum-raw-binaries branch September 3, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址