Repository navigation
Make sure Goreleaser checksums cover all binaries - #190
Conversation
The ahoy-bin-* binaries reach the release through release.extra_files, which bypasses the checksum pipe, so they shipped with no checksums at all. v3.0.1 lists 20 entries for 30 artifacts: the archives and the SBOMs, but none of the binaries. The same gap is in v3.0.0, and in v2.5.0 before the goreleaser rework. It matters because the raw binaries are what the documented install one-liner downloads, so the artifacts people actually run were the ones they could not verify, while the archives nobody installs from were fully covered. checksum.extra_files takes the same globs as release.extra_files. Verified with a full snapshot build: the checksums file goes from 20 entries to 30, covering every non-checksum asset, with no duplicates between the two globs, and the recorded hashes match the built files. Claude-Session: https://claude.ai/code/session_01629NFuQxTr678Tdh8AD39d
Signed-off-by: Drew Robinson <drew.robinson@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe release configuration now generates checksums for regular and static raw binaries. The README updates the Sponsors section and corrects contributor image width attributes. ChangesRelease checksum coverage
README metadata
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Release checksums now cover the intended raw binaries, and the documentation metadata updates are safe. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Release Improvements
Documentation