Repository navigation
Refactor to remove dead stderr capture pipe and improve subprocess handling - #184
Conversation
Follow-up to ahoy-cli#181, which fixed the symptom of ahoy-cli#180 by handing subprocesses the stderr captured at startup. The pipe it worked around is itself dead code: it was added in 3aa069a to intercept cobra's error output, and that job has since moved to SilenceErrors plus the error translation in main(). What remained copied stderr to stderr, achieving nothing but the loss of fd 2's terminal properties - and needed a drain goroutine to avoid the deadlock it introduced. Removing it lets subprocesses use os.Stderr directly again and drops the commandStderr indirection from appState. The Go test is reframed to assert the behaviour rather than the mechanism, and a BATS test now pins the descriptor kind end to end - verified to fail against master and pass with the fix. Claude-Session: https://claude.ai/code/session_01629NFuQxTr678Tdh8AD39d
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughAhoy no longer routes stderr through an internal pipe. Ahoy and its subprocesses use the original ChangesStderr inheritance
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes a dead stderr capture pipe and refines subprocess handling; no actionable merge-blocking risk remains based on the supplied evidence. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Bug Fixes
Tests