Repository navigation
Fix for #100 : Stop -- parameter being passed literally to command - #101
Merged
Merged
Conversation
ocean
marked this pull request as ready for review
August 4, 2022 07:45
Member
Author
|
Fix for #100 for review @AlexSkrypnyk - I've also put out a pre-release so people can grab and test if they like, at https://github.com/ahoy-cli/ahoy/releases/tag/2.0.2-alpha |
AlexSkrypnyk
approved these changes
Aug 5, 2022
AlexSkrypnyk
left a comment
Collaborator
There was a problem hiding this comment.
@ocean
LGTM
Thank you so much for picking this up so fast!
Member
Author
|
Ok, I'll put out a full release for this and update Homebrew. |
This was referenced Sep 2, 2026
ocean
added a commit
that referenced
this pull request
Sep 2, 2026
Ahoy removed every '--' a user typed, so a separator meant as data never reached the wrapped tool. That silently changed the request for anything needing one of its own: kubectl exec, npm run, cargo run, git checkout. The worst case is git. With a branch and a file sharing a name, 'ahoy git checkout -- deploy' arrived as 'git checkout deploy', so a request to discard edits to a file switched branch instead and left the edits in place. The strip came from #101, fixing #100 ('ahoy up -- --build' reaching docker-compose as '-- --build'). The intent there was that a leading '--' shields what follows, which urfave/cli needed at the time; the implementation stripped every occurrence instead of the first. Since #182 ahoy no longer parses a command's arguments at all, so a leading '--' is now only a readability habit, but scripts still use it and honouring it costs nothing. Now: a leading '--' is consumed, every later one is the command's data. Claude-Session: https://claude.ai/code/session_01629NFuQxTr678Tdh8AD39d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.