Skip to content

needs/if should prevent errors about nested jobs violating permissions #4151

Open

Description

@jsoref

context.Error(workflowJob.Id, $"Error calling workflow '{workflowJob.Ref}'. The nested job '{embeddedJob.Id!.Value}' is requesting '{requestedStr}', but is only allowed '{allowedStr}'.");

https://github.com/check-spelling-sandbox/rancher-dashboard/actions/runs/20184527336/workflow

Workflow failure

Annotations

1 error
Invalid workflow file: .github/workflows/test-extension-workflows-release-2.8.yml#L63
The workflow is not valid. .github/workflows/test-extension-workflows-release-2.8.yml (Line: 63, Col: 3): Error calling workflow 'rancher/dashboard/.github/workflows/release-shell-pkg.yaml@release-2.8'. The nested job 'build' is requesting 'packages: write', but is only allowed 'packages: read'.


Repository authors will do this (this repository did it repeatedly) and there doesn't seem to be a good reason to demand authors get this right.

There doesn't appear to be any way to guard against this, as even if doesn't help:

https://github.com/check-spelling-sandbox/rancher-dashboard/actions/runs/20199790260/workflow

Image

Annotations

1 error
Invalid workflow file: .github/workflows/test-extension-workflows-release-2.9.yml#L64
The workflow is not valid. .github/workflows/test-extension-workflows-release-2.9.yml (Line: 64, Col: 3): Error calling workflow 'rancher/dashboard/.github/workflows/release-shell-pkg.yaml@release-2.9'. The nested job 'build' is requesting 'packages: write', but is only allowed 'packages: read'.

Activity

  1. changed the title [-]`needs` should prevent errors about nested jobs violating permissions[/-] [+]`needs`/`if` should prevent errors about nested jobs violating permissions[/+] on Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址