Repository navigation
feat: add capture-on-miss-flag - #1229
Conversation
|
Claude finished @tommysitu's task in 2m 34s —— View job Code Review
The implementation is clean and follows existing patterns well. A few issues to address: Bug: Silent ignore when
|
|
Hi @schthms, the change is sensible, just some minor issues spotted by claude which you might want to address as well. |
|
Thanks @tommysitu. I addressed the review comments:
|
tommysitu
left a comment
There was a problem hiding this comment.
Adding new flag to hoverfly cli, no-ops for existing feature. LGTM
hoverfly 1.12.8 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What's Changed * Add Claude Code GitHub Workflow by @tommysitu in SpectoLabs/hoverfly#1223 * Bump Go to 1.26.3 by @maicodio in SpectoLabs/hoverfly#1224 * Migrate Renovate config by @renovate[bot] in SpectoLabs/hoverfly#1226 * fix: race in Diff mode crashes Hoverfly (GHSA-qrh4-p6v4-mrfg) by @tommysitu in SpectoLabs/hoverfly#1227 * fix(action): timeout remote post-serve HTTP client (GHSA-42j2-w334-qxw7) by @tommysitu in SpectoLabs/hoverfly#1228 * feat: add capture-on-miss-flag by @schthms in SpectoLabs/hoverfly#1229 ## New Contributors * @maicodio made their first contribution in SpectoLabs/hoverfly#1224 * @renovate[bot] made their first contribution in SpectoLabs/hoverfly#1226 * @schthms made their first contribution in SpectoLabs/hoverfly#1229 **Full Changelog**: https://github.com/SpectoLabs/hoverfly/compare/v1.12.7...v1.12.8</pre> <p>View the full release notes at <a href="https://github.com/SpectoLabs/hoverfly/releases/tag/v1.12.8">https://github.com/SpectoLabs/hoverfly/releases/tag/v1.12.8</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!9861
Adds a -capture-on-miss CLI flag that, when combined with -spy, configures spy mode to save request/response pairs to the simulation store on cache misses. Previously this behavior was only configurable via the admin API after startup.
Also adds unit tests covering the CaptureOnMiss path in spy mode and the SetModeWithArguments wiring for the new argument.