Repository navigation
Fix release.sh CMakeLists version check - #424
Merged
Merged
Conversation
Version is now declared as project(libcbor VERSION x.y.z) rather than separate set(CBOR_VERSION_MAJOR ...) variables. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The version check in
release.shgrepped forset(CBOR_VERSION_MAJORwhich no longer exists — the project version is now declared asproject(libcbor VERSION x.y.z). The grep returned no output, causing the script to fail underset -e.Test plan
release.shand confirm the CMakeLists check prints the project version line correctly🤖 Generated with Claude Code