Repository navigation
Fix NULL dereference in cbor_copy/cbor_copy_definite on allocation failure - #419
Merged
Merged
Conversation
…ilure Three spots dereferenced the result of an allocation without a NULL check: - _cbor_copy_int: cbor_mark_negint(res) called even if cbor_build_uint* returned NULL (reported in issue #417) - cbor_copy_definite bytestring: cbor_bytestring_set_handle called on NULL res; also leaked combined_data on failure - cbor_copy_definite string: same pattern as bytestring Each fix adds an early return NULL (with _cbor_free of any already-allocated buffer) before the dereference. Tests added for all three paths, including the specific case where the item allocation fails after the buffer allocation succeeds. Fixes #417 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 20 20
Lines 1747 1754 +7
=======================================
+ Hits 1746 1753 +7
Misses 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #417.
Summary
_cbor_copy_int:cbor_mark_negint(res)was called unconditionally after the switch, even if the precedingcbor_build_uint*()returned NULL on allocation failure. Added earlyreturn NULLbefore the dereference.cbor_copy_definitebytestring:cbor_bytestring_set_handlewas called on a potentially-NULLresfromcbor_new_definite_bytestring(). Added early return with_cbor_free(combined_data)to avoid the dereference and the buffer leak.cbor_copy_definitestring: identical pattern to the bytestring case, same fix.Test plan
test_negint{8,16,32,64}_alloc_failure) — confirmcbor_copyreturns NULL rather than crashing when allocation failstest_definite_bytestring_item_alloc_failure— covers the path wherecombined_datamalloc succeeds butcbor_new_definite_bytestringfailstest_definite_string_item_alloc_failure— same for stringscopy_testcases pass🤖 Generated with Claude Code