Repository navigation
Modernize CMake build system - #402
Merged
Merged
Conversation
Use project(VERSION ...) instead of manual version variables, replace global add_definitions() with target-scoped target_compile_definitions(), remove redundant include_directories(src), remove deprecated CBOR_CUSTOM_ALLOC option, and simplify LTO version check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
project(VERSION 0.13.0 ...)instead of manualset(CBOR_VERSION_*)variablesadd_definitions()with target-scopedtarget_compile_definitions()(PRIVATE for internal-only defines, PUBLIC for defines used in public headers)include_directories(src)(already handled bytarget_include_directoriesinsrc/CMakeLists.txt)CBOR_CUSTOM_ALLOCoption (was a no-op with deprecation warning since 0.10.0)VERSION_GREATER_EQUALTest plan
-DWITH_TESTS=ON -DSANITIZE=ONsucceedsconfiguration.hhas correct version numberslibcbor.pchas correct versionadd_definitionsremain inCMakeLists.txt🤖 Generated with Claude Code