Skip to content

Build system cleanup - #394

Merged
PJK merged 3 commits into
masterfrom
cleanup-inline-specifier
Feb 8, 2026
Merged

PJK merged 3 commits into
masterfrom
cleanup-inline-specifier

Conversation

@PJK

@PJK PJK commented Feb 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove dead CBOR_INLINE_SPECIFIER macro (never set by CMake, never used)
  • Detect Debian package architecture via dpkg instead of hardcoding amd64
  • Replace hardcoded make -j 16 in llvm-coverage target with portable cmake --build . --parallel

Test plan

  • CMake configure succeeds
  • All 26 tests pass

🤖 Generated with Claude Code

PJK and others added 3 commits February 8, 2026 19:17
The macro was never set by CMake and never used in the codebase.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instead of hardcoding amd64, query dpkg for the correct architecture.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace hardcoded `make -j 16` with a portable and adaptive command.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@PJK
PJK merged commit 5dc4367 into master Feb 8, 2026
15 of 16 checks passed
@PJK
PJK deleted the cleanup-inline-specifier branch February 8, 2026 18:23
@codecov

codecov Bot commented Feb 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e87cc36) to head (f439d6b).
⚠️ Report is 30 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #394      +/-   ##
===========================================
+ Coverage   99.87%   100.00%   +0.12%     
===========================================
  Files          20        20              
  Lines        1663      1663              
===========================================
+ Hits         1661      1663       +2     
+ Misses          2         0       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

⌂ 换网址