Repository navigation
Fix integer overflow in cbor_copy_definite() chunk accumulation - #387
Merged
Merged
Conversation
When flattening indefinite bytestrings/strings, chunk lengths were summed without overflow checks. Crafted chunks summing past SIZE_MAX would wrap around, causing a small allocation followed by a heap buffer overflow in memcpy. Use _cbor_safe_to_add() to detect overflow and return NULL. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1653 1657 +4
=========================================
+ Hits 1653 1657 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cbor_copy_definite()for indefinite bytestrings and stringsSIZE_MAXwould silently wrap around, causing a small_cbor_mallocfollowed by heap buffer overflow inmemcpy_cbor_safe_to_add()to detect overflow and returnNULLTest plan
test_definite_indef_bytestring_chunk_length_overflow— verifiescbor_copy_definite()returns NULL when bytestring chunk lengths would overflowtest_definite_indef_string_chunk_length_overflow— same for strings🤖 Generated with Claude Code