Skip to content

Export and install CMake targets - #337

Merged
PJK merged 1 commit into
PJK:masterfrom
dg0yt:cmake
Dec 7, 2024
Merged

PJK merged 1 commit into
PJK:masterfrom
dg0yt:cmake

Conversation

@dg0yt

@dg0yt dg0yt commented Nov 24, 2024 •

Copy link
Copy Markdown
Contributor

Description

libcbor already installed a cmake config file but it didn't provide linking information. This PR adds canonical export of the library, offering all usage properties via the imported target libcbor::libcbor.

  find_package(libcbor CONFIG REQUIRED)
  target_link_libraries(main PRIVATE libcbor::libcbor)

Checklist

  • I have read followed CONTRIBUTING.md
    • I have added tests
    • I have updated the documentation
    • I have updated the CHANGELOG
  • Are there any breaking changes?
    • If yes: I have marked them in the CHANGELOG (example)
  • Does this PR introduce any platform specific code?
  • Security: Does this PR potentially affect security?
  • Performance: Does this PR potentially affect performance?

@dg0yt

dg0yt commented Nov 24, 2024

Copy link
Copy Markdown
Contributor Author

A variant of this change is in microsoft/vcpkg#42341. There, the CMake config is consumed by libfido2.

@codecov

codecov Bot commented Nov 24, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5369727) to head (04c852c).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #337   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         1662      1662           
=========================================
  Hits          1662      1662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PJK

PJK commented Dec 7, 2024

Copy link
Copy Markdown
Owner

Thank you!

@PJK
PJK merged commit 34cf74b into PJK:master Dec 7, 2024
@dg0yt
dg0yt deleted the cmake branch December 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址