Repository navigation
Fix UTF-8 codepoint counting in cbor_string_set_handle and parsing - #286
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 99.39% 99.27% -0.13%
==========================================
Files 20 20
Lines 1665 1664 -1
==========================================
- Hits 1655 1652 -3
- Misses 10 12 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 4, 2024
0.11.0 (2024-02-04) --------------------- - [Updated documentation to refer to RFC 8949](PJK/libcbor#269) - Improvements to `cbor_describe` - [Bytestring data will now be printed as well](PJK/libcbor#281) by [akallabeth](https://github.com/akallabeth) - [Formatting consistency and clarity improvements](PJK/libcbor#285) - [Fix `cbor_string_set_handle` not setting the codepoint count](PJK/libcbor#286) - BREAKING: [`cbor_load` will no longer fail on input strings that are well-formed but not valid UTF-8](PJK/libcbor#286) - If you were relying on the validation, please check the result using `cbor_string_codepoint_count` instead - BREAKING: [All decoders like `cbor_load` and `cbor_stream_decode` will accept all well-formed tag values](PJK/libcbor#308) (bug discovered by [dskern-github](https://github.com/dskern-github)) - Previously, decoding of certain values would fail with `CBOR_ERR_MALFORMATED` or `CBOR_DECODER_ERROR` - This also makes decoding symmetrical with serialization, which already accepts all values
msk
pushed a commit
to msk/pkgsrc
that referenced
this pull request
May 11, 2026
0.11.0 (2024-02-04) --------------------- - [Updated documentation to refer to RFC 8949](PJK/libcbor#269) - Improvements to `cbor_describe` - [Bytestring data will now be printed as well](PJK/libcbor#281) by [akallabeth](https://github.com/akallabeth) - [Formatting consistency and clarity improvements](PJK/libcbor#285) - [Fix `cbor_string_set_handle` not setting the codepoint count](PJK/libcbor#286) - BREAKING: [`cbor_load` will no longer fail on input strings that are well-formed but not valid UTF-8](PJK/libcbor#286) - If you were relying on the validation, please check the result using `cbor_string_codepoint_count` instead - BREAKING: [All decoders like `cbor_load` and `cbor_stream_decode` will accept all well-formed tag values](PJK/libcbor#308) (bug discovered by [dskern-github](https://github.com/dskern-github)) - Previously, decoding of certain values would fail with `CBOR_ERR_MALFORMATED` or `CBOR_DECODER_ERROR` - This also makes decoding symmetrical with serialization, which already accepts all values
jperkin
pushed a commit
to TritonDataCenter/pkgsrc
that referenced
this pull request
May 14, 2026
0.11.0 (2024-02-04) --------------------- - [Updated documentation to refer to RFC 8949](PJK/libcbor#269) - Improvements to `cbor_describe` - [Bytestring data will now be printed as well](PJK/libcbor#281) by [akallabeth](https://github.com/akallabeth) - [Formatting consistency and clarity improvements](PJK/libcbor#285) - [Fix `cbor_string_set_handle` not setting the codepoint count](PJK/libcbor#286) - BREAKING: [`cbor_load` will no longer fail on input strings that are well-formed but not valid UTF-8](PJK/libcbor#286) - If you were relying on the validation, please check the result using `cbor_string_codepoint_count` instead - BREAKING: [All decoders like `cbor_load` and `cbor_stream_decode` will accept all well-formed tag values](PJK/libcbor#308) (bug discovered by [dskern-github](https://github.com/dskern-github)) - Previously, decoding of certain values would fail with `CBOR_ERR_MALFORMATED` or `CBOR_DECODER_ERROR` - This also makes decoding symmetrical with serialization, which already accepts all values
This was referenced Sep 16, 2026
PJK
added a commit
that referenced
this pull request
Sep 16, 2026
The strings documentation still claimed that invalid UTF-8 is rejected by the parser, which has not been true since 0.11.0 (#286). Replace it with an accurate description of cbor_string_codepoint_count-based checking and add a single section in decoding.rst stating the policy: decoders check RFC 8949 Section 3 well-formedness only, and Section 5.3 validity (UTF-8 encoding, duplicate map keys, tag content types) is left to the application. Cross-reference it from the strings, maps, and tags pages. Prompted by #440. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
tsutsui
pushed a commit
to tsutsui/pkgsrc
that referenced
this pull request
Oct 17, 2026
0.11.0 (2024-02-04) --------------------- - [Updated documentation to refer to RFC 8949](PJK/libcbor#269) - Improvements to `cbor_describe` - [Bytestring data will now be printed as well](PJK/libcbor#281) by [akallabeth](https://github.com/akallabeth) - [Formatting consistency and clarity improvements](PJK/libcbor#285) - [Fix `cbor_string_set_handle` not setting the codepoint count](PJK/libcbor#286) - BREAKING: [`cbor_load` will no longer fail on input strings that are well-formed but not valid UTF-8](PJK/libcbor#286) - If you were relying on the validation, please check the result using `cbor_string_codepoint_count` instead - BREAKING: [All decoders like `cbor_load` and `cbor_stream_decode` will accept all well-formed tag values](PJK/libcbor#308) (bug discovered by [dskern-github](https://github.com/dskern-github)) - Previously, decoding of certain values would fail with `CBOR_ERR_MALFORMATED` or `CBOR_DECODER_ERROR` - This also makes decoding symmetrical with serialization, which already accepts all values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cbor_string_set_handle