Repository navigation
Fixes memory leak in cbor_bytestring_add_chunk - #228
Merged
PJK merged 1 commit intoDec 25, 2022
Merged
Conversation
James-ZHANG
force-pushed
the
fix-memory-leak-in-bytestring-add-chunk
branch
from
December 22, 2022 00:07
c0782c0 to
8cf378c
Compare
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
- Coverage 95.96% 95.65% -0.32%
==========================================
Files 20 20
Lines 1538 1543 +5
==========================================
Hits 1476 1476
- Misses 62 67 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Owner
|
Nice catch, thanks! Also filed #231 to improve test coverage |
PJK
added a commit
that referenced
this pull request
Dec 27, 2022
2 of 9 tasks
PJK
added a commit
that referenced
this pull request
Dec 27, 2022
PJK
added a commit
that referenced
this pull request
Dec 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Fixes memory leak in
cbor_bytestring_add_chunkDescription
The passed
chunkis not freed whencbor_bytestring_add_chunkreturnsfalse.Checklist
No
No
No
No