Skip to content

Make the buffer_size optional in cbor_serialize_alloc() - #205

Merged
PJK merged 1 commit into
PJK:masterfrom
hughsie:wip/hughsie/cbor_serialize_alloc-no-size
Mar 17, 2022
Merged

PJK merged 1 commit into
PJK:masterfrom
hughsie:wip/hughsie/cbor_serialize_alloc-no-size

Conversation

@hughsie

@hughsie hughsie commented Mar 14, 2022 •

Copy link
Copy Markdown
Contributor

PR: Make the buffer_size optional in cbor_serialize_alloc()

Description

In my case I don't care exactly how many bytes were allocated, I just need the number of bytes the CBOR item serialized to.

Checklist

  • I have read followed CONTRIBUTING.md
    • I have added tests
    • I have updated the documentation
    • I have updated the CHANGELOG

@PJK PJK left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thank you for the improvement. Please address the comments and merge master to get #206

Comment thread test/cbor_serialize_test.c Resolved
Comment thread test/cbor_serialize_test.c Resolved
In my case I don't care exactly how many bytes were allocated, I just
need the number of bytes the CBOR item serialized to.
@PJK

PJK commented Mar 15, 2022

Copy link
Copy Markdown
Owner

Thanks for the changes, please merge the up to date master branch and I'll merge this PR.

@hughsie

hughsie commented Mar 15, 2022

Copy link
Copy Markdown
Contributor Author

please merge the up to date master branch

Bit confused; didn't I do that? I see this branch being one ahead of origin/master.

@PJK

PJK commented Mar 17, 2022

Copy link
Copy Markdown
Owner

Sorry, my bad, you're right. CI wasn't correctly configured to run for PRs.

PJK added a commit that referenced this pull request Mar 17, 2022
@PJK
PJK merged commit ee9a7d8 into PJK:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址