[andyjgf]

PR: Add an example to the examples directory, showing how to use libcbor with Bazel

Description

Add an example to the examples directory, showing how to use libcbor with Bazel

Checklist

• [ x] I have read followed CONTRIBUTING.md
  • [x ] I have added tests
  • [ x I have updated the documentation
  • [x ] I have updated the CHANGELOG
• [n ] Are there any breaking changes? If so, are they documented?
• [n ] Does this PR introduce any platform specific code? If so, is this captured in the description?
• [n ] Security: Does this PR potentially affect security? If so, is this captured in the description?
• [n ] Performance: Does this PR potentially affect performance? If so, is this captured in the description?

[PJK]

Awesome, thank you!

Could you please take a look at the comment I left inline? Maybe I'm just missing something.
We should also add this to the CI script to make sure it doesn't get broken.

[andyjgf]

I don't see a comment, which file?
And where is the CI script?

[PJK]

In examples/bazel/third_party/libcbor.BUILD, the cc_import rule is commented out

The script section of https://github.com/PJK/libcbor/blob/master/.travis.yml should basically also build the example. I can take a look at this.

[andyjgf]

I fixed the BUILD file. I don't see that yml file... I'm still kind of a newbie about GitHub....

…

On Sun, Oct 10, 2021 at 11:04 AM Pavel Kalvoda ***@***.***> wrote: In examples/bazel/third_party/libcbor.BUILD, the cc_import rule is commented out The script section of https://github.com/PJK/libcbor/blob/master/.travis.yml should basically also build the example. I can take a look at this. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#196 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK5GJQT5SU2U3ETEBTCUDIDUGHIT5ANCNFSM5FDHMP6A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Andrew John, Google Fonts

[codecov-commenter]

Codecov Report

Merging #196 (047eaee) into master (2cf83af) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   95.60%   95.48%   -0.13%     
==========================================
  Files          47       47              
  Lines        3325     3325              
  Branches      172      172              
==========================================
- Hits         3179     3175       -4     
- Misses         98      101       +3     
- Partials       48       49       +1     

Impacted Files	Coverage Δ
test/fuzz_test.c	83.33% <0.00%> (-8.34%)	⬇️
src/cbor/streaming.c	97.54% <0.00%> (-0.99%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf83af...047eaee. Read the comment docs.

[PJK]

This is what I meant: 72dc859