Repository navigation
Conversation
PJK
added a commit
that referenced
this pull request
Oct 25, 2026
* Stop linking the math library The check for ldexp and the conditional -lm were added in #170 because _cbor_decode_half called ldexp, which lives in libm on e.g. NetBSD. Since #453 the library no longer calls it; its remaining <math.h> uses are the isnan and NAN macros, which need no libm (NetBSD implements __isnanf in libc). Link the cjson2cbor example against libm itself since it calls fabs and could previously have relied on libcbor to pull libm in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0191nuQHmM9MpnzoHTkUwqXT * CHANGELOG: math library linkage Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0191nuQHmM9MpnzoHTkUwqXT --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169