Skip to content

Improve cbor_stream_decode interface - #156

Merged
PJK merged 7 commits into
masterfrom
pk/nedata
Sep 6, 2020
Merged

PJK merged 7 commits into
masterfrom
pk/nedata

Conversation

@PJK

@PJK PJK commented Sep 6, 2020

Copy link
Copy Markdown
Owner
  • Remove CBOR_DECODER_EBUFFER as it was never used and provides no benefit over NEDATA
  • Change cbor_decoder_result.required to correctly account for all the data needed to proceed
  • Add test coverage
  • Improve comments & documentation
  • Minor code cleanup

Closes #106

@codecov-commenter

codecov-commenter commented Sep 6, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #156 into master will increase coverage by 4.26%.
The diff coverage is 88.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   88.43%   92.69%   +4.26%     
==========================================
  Files          53       52       -1     
  Lines        3561     3452     -109     
  Branches      198      199       +1     
==========================================
+ Hits         3149     3200      +51     
+ Misses        332      198     -134     
+ Partials       80       54      -26     
Impacted Files Coverage Δ
src/cbor.c 97.83% <ø> (ø)
test/assertions.c 0.00% <0.00%> (ø)
src/cbor/streaming.c 96.29% <84.78%> (+11.11%) ⬆️
test/cbor_stream_decode_test.c 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3500c...b3ce6bb. Read the comment docs.

@PJK
PJK merged commit eef1698 into master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_cbor_claim_bytes calculates wrong required for strings and bytestrings

2 participants

⌂ 换网址