Repository navigation
fail stream decoding whenever the context stack size reaches a threshold - #138
Merged
Merged
Conversation
James-ZHANG
force-pushed
the
limit-stack-size
branch
from
March 30, 2020 18:29
937ac37 to
421d661
Compare
Contributor
Author
|
Hi, Pavel, |
PJK
requested changes
Apr 7, 2020
Owner
There was a problem hiding this comment.
Overall LGTM, I have three requests:
1/ As you say, could you please move this to be a build-time constant? There is no autotools header files, https://github.com/PJK/libcbor/blob/master/CMakeLists.txt#L22 would be the right place
2/ Please add tests exercising the new behavior
3/ 255 seems sort of low. Are you aware of any datasets or resources that would could provide a good empirical estimate of what is common "in the wild"? If not, I would stay on the safe side and bump this to something generous, say 2k.
Thanks for driving this forward!
Contributor
Author
|
Tests added and did some refactoring of memory allocation macros. |
PJK
approved these changes
Apr 8, 2020
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now this threshold is set to 255. Maybe it's better to make it a config value in configuration.h.in?