Skip to content

Possible typo in float-16 NaN encoding #53

Closed

Description

@BrianSipos

In current master/src/cbor/encoding.c line 140, there appears to be a constant encoded value for 16-bit float NaN value as 0x00e700. I think this is a typo as RFC 7049 in Section 3.9 states that

If NaN is an allowed value, it must always be represented as 0xf97e00

Notice the first data octet difference e7 vs 7e.
The same 7e00 encoding comes up in the RFC 7049 NaN example in Appendix A.

Activity

  1. PJK commented on Mar 12, 2017

    @PJK
    Owner

    Yup, looks like you are right. Thanks for reporting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址