Skip to content

Reference counting on cbor_tag_item #109

Closed

Description

@JohnGilmour

cbor_item_t *cbor_tag_item(const cbor_item_t *item)
Get the tagged item.
Return
incref the tagged item
Parameters
item[borrow]: A tag

This API does not increment the reference count so either the documentation is incorrect or the code is. The result of this is a system crash, primarily due to the change that checks the reference count:
35b2601#diff-b6e6b92852165166e4fca6a6279cb519

Activity

  1. PJK commented on Sep 2, 2020

    @PJK
    Owner

    Well spotted, thank you @JohnGilmour! I guess this API is so obscure that no one else ever noticed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      ⌂ 换网址