You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
testImports fail to install with glide install and glide.lock present #517
I have a project which doesn't have any dependencies except for Ginkgo and Gomega for tests. My glide.yaml is (placeholder package_path since this is a private repo):
I also have a glide.lock file which is populated with the latest versions from my dev machine.
glide install fails as follows:
> glide --debug install
[DEBUG] Creating vendor
[INFO] No dependencies found. Nothing installed.
[INFO] Setting references.
[ERROR] Failed to set version on github.com/onsi/gomega to a78ae492d53aad5a7a232d0d0462c14c400e3ee7: open /go/src/<package_path>/vendor/github.com/onsi/gomega: no such file or directory
[ERROR] Failed to set version on github.com/onsi/ginkgo to 462326b1628e124b23f42e87a8f2750e3c4e2d24: open /go/src/<package_path>/vendor/github.com/onsi/ginkgo: no such file or directory
It appears that it's skipping test dependencies during the download phase but not afterward. I can't find any option to make it download test deps, only --skip-test which seems to be the reverse.
Changing to glide up works, but I believe this is more costly, and I shouldn't have to make my CI build re-scan the dependencies? Bug?
I am seeing this same issue sporadically, I haven't be able to identify the trigger though. Strangely when I check the vendor directory the dependency is both present and set to the correct version
There are two separate bugs listed here. One is the case where there are testImports but no imports. The second has to do with something being listed in both imports and testImports.
Activity
prashantv commentedon Aug 3, 2016
I tried to update a package to use
testImportand hit a similar issue,argon commentedon Aug 4, 2016
I am seeing this same issue sporadically, I haven't be able to identify the trigger though. Strangely when I check the vendor directory the dependency is both present and set to the correct version
mattfarina commentedon Aug 5, 2016
Does the dependency, currently listed under
testImportalso show up in non-test code?@sinbad thanks for sharing the
glide.yamlfile. I can use that to try and replicate the problem.prashantv commentedon Aug 5, 2016
@mattfarina You can see the full glide.yaml and glide.lock causing failures here:
yarpc/yab#95
There is no overlap between the normal imports and test imports:
https://github.com/yarpc/yab/blob/eaaea58e33966aea27e4d8545131d3fc4b5c3d73/glide.yaml
mattfarina commentedon Aug 11, 2016
There are two separate bugs listed here. One is the case where there are testImports but no imports. The second has to do with something being listed in both imports and testImports.
Fix coming soon.
Fixed #517 failed to install testImport from lock
Fixed #517 failed to install testImport from lock
mattfarina commentedon Aug 11, 2016
Anyone interested can test the fix on #545. If there are no complaints I'll merge on Friday.
Merge pull request #545 from Masterminds/fix/517