Repository navigation
build: replace deprecated mholt/archiver to resolve the klauspost/compress alert - #36
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Tested against a Flutter app for regression checking: $ go build -o /tmp/mpc-new
$ rm -rf /tmp/fv && mkdir /tmp/fv && cd /tmp/fv && unzip -q ~/Downloads/fixed/flutter_view_debug.app.zip && ls
fluter_view_debug.app
$ NEW_NO=$(/tmp/mpc-new upload-app -a ./flutter_view_debug.app) && echo $NEW_NO
15
$ /tmp/mpc-new batch-run -S 10 -s "{\"app_file_number\":\"${NEW_NO}\"}"
test result page:
https://app.magicpod.com/<org>/<proj>/batch-run/12/
#12 wait until 1 tests to be finished..
.........1/1 finished
...batch run succeededAn iSO cloud device also launched in the test case editing page. |
Contributor
Author
|
Tested against a Flutter app with symlinks Setup: Failure reproduced with 1.38: Succeeded in this branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Proposed changes.
Resolve the alert, bump the version to
1.75.0.1and addmise.tomlto pin thegoversion.klauspost/compressv1.18.7 directly, sincemholt/archivesv0.1.5 still requires v1.18.0.Tests against
AVCamand an iOS deviceZips produced by the old and new binaries are identical (entries, permissions, extracted contents, symlinks):
upload-fileand batch run: