Skip to content

fix: not to delete branch when setting is included - #33

Merged
kousuketk merged 1 commit into
mainfrom
fix/branch-parameter-with-setting
Mar 31, 2026
Merged

kousuketk merged 1 commit into
mainfrom
fix/branch-parameter-with-setting

Conversation

@kousuketk

@kousuketk kousuketk commented Mar 31, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

When setting str (-s) is included, branch info is deleted.
However, a branch info should not be deleted regardless of the existence of the setting str.

This change is needed to support a branch on bitrise-step-magic-pod because app_file_number is added as settingsStr.

What I checked

I checked the behavior like this command.

$ ./magicpod-api-client batch-run -n -t ${MAGIC_POD_AUTH_TOKEN_PROD} -o <organization> -p <project> -S <test_settings_number>
-B <branch> -s "{\"app_file_number\": 20}"
  • Before this change, a branch was ignored.
  • After this change, a branch is reflected as expected.

@kousuketk
kousuketk requested review from f1047 and mwakizaka March 31, 2026 04:05

@mwakizaka mwakizaka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Makes sense!

@f1047 f1047 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kousuketk
kousuketk merged commit 0bf3f1c into main Mar 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

⌂ 换网址