Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #250 and the review of #289 on the
shear_deformationbranch.What this adds
Testing/test_shear_deformable_members.pychecks shear-deformable members against closed-form Timoshenko beam solutions: the Euler-Bernoulli bending term plus the shear term from integrating V/(kGA) along the member. A timber-like section (E/G = 16, 0.2 m x 0.6 m, k = 5/6) is used so the shear term is a large share of each result.Passing checks (all agree to
rel_tol=1e-9):member.deflection()at x = L.shear_deformable=Falsereduces to Euler-Bernoulli.Iyandkszare paired.These cover the modified stiffness matrix, the fixed-end reactions, and a statically indeterminate case, so they should help with the review of #289.
Interior deflections omit the shear term
Two tests are marked
xfail(strict=True)because they fail on this branch. Between nodes,member.deflection()returns the Euler-Bernoulli value for a shear-deformable member. For the section above, the midspan deflection of a single simply supported member is underestimated by 38% under uniform load and 43% under a midspan point load; for a fixed-fixed member it is 75%. Deflections at nodes are correct.The cause appears to be that
BeamSegZ.deflection()andBeamSegY.deflection()integrate curvature only, and_segment_member()infers the starting slopetheta1from the Euler-Bernoulli slope-deflection relation (Member3D.py around line 2685). The end conditions are therefore met, but the shape between them is the Euler-Bernoulli shape. For a shear-deformable member the missing term is (M(x) - M1)/(kGA) within a segment, andtheta1would need the matching correction. I did not change this here because it touches the segment classes and the P-Delta path; I am happy to open a follow-up PR if you would like that approach. Withstrict=True, these two tests will start failing as unexpected passes once the behavior is fixed, as a reminder to remove the markers.Testing
Full suite on this branch: 91 passed and 2 xfailed (85 passed before this change).
The expected values are written out in the tests. While preparing them I also cross-checked the cantilever and simply supported cases against timoshenko-engine, a small library I maintain, which gave identical values. The tests do not depend on it.