[dduugg]

• Pass explicit keywords to validate_url_for_https_availability so brew typecheck catches a mistyped keyword at its three callers, which options: T.untyped hid.
• Narrow Cask::URL#user_agent to non-nil, since URL#initialize always stores user_agent || :default.
• Pass the binary URL's referer to curl_check_http_content as a String, as SystemCommand already did when building the curl arguments.
• Cover the binary URL HTTPS audit with and without a referer in unit tests.

---

• Have you followed our Contributing guidelines?
• Have you checked for other open Pull Requests for the same change?
• Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
• Have you explained why you'd like these changes included, not just what they do?
• For bug fixes, have you given step-by-step brew commands to reproduce the bug?
• Have you written new tests (excluding integration tests)? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) locally?

---

• I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; every commit has a human author or co-author and I will answer maintainer questions and review comments myself without AI/LLM.

Claude Code with Opus 5.5, with local review and testing.

---

[coderabbitai]

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability of HTTPS availability checks when a referring URL is provided, including when no referrer is available.
  • Cask URLs now consistently use a valid user-agent value, with a default applied when one is not supplied.
• Tests
  • Added coverage for binary URL HTTPS checks with and without a referring URL, including verification of the relevant check options.

The cask URL user-agent type is now non-nullable. HTTPS availability audits convert referers to strings and pass explicit keyword options to the HTTP content check. Tests cover binary URL audits with and without a referer.

Changes: Cask HTTPS availability audit

Layer / File(s)	Summary
Cask URL user-agent type Library/Homebrew/cask/url.rb	The user_agent reader and stored value use a non-nullable type. Initialization retains the :default fallback.
HTTPS audit argument forwarding Library/Homebrew/cask/audit.rb, Library/Homebrew/test/cask/audit_spec.rb	The audit converts the referer to a string. The validation method forwards explicit keyword options to curl_check_http_content. Tests cover binary URL checks with absent and present referers.

Merge Risk: Minimal · up to ae4d3

No actionable issue is established for the cask HTTPS audit changes; the PR is mergeable after normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title 'Type cask audit options instead of **options' matches the main change. The PR replaces the variadic **options in validate_url_for_https_availability with explicit typed keyword parame…
Description check		The description states the purpose of each change: explicit keywords for validate_url_for_https_availability, narrowing Cask::URL#user_agent to non-nil, passing the referer as a String, and adding…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title 'Type cask audit options instead of **options' matches the main change. The PR replaces the variadic **options in validate_url_for_https_availability with explicit typed keyword parameters, which the raw summary and objectives both confirm.

Full details: Description check

Explanation

The description states the purpose of each change: explicit keywords for validate_url_for_https_availability, narrowing Cask::URL#user_agent to non-nil, passing the referer as a String, and adding unit tests. These match the raw summary and objectives.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 239aabc1-c24a-4f7d-8a74-80dbb0fa1298

Commits

Reviewing files that changed from the base of the PR and between 25ccd49 and ae4d31c.

Files selected for processing: 3

• Library/Homebrew/cask/audit.rb
• Library/Homebrew/cask/url.rb
• Library/Homebrew/test/cask/audit_spec.rb

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.