Skip to content

Skip disabled packages in outdated reports - #24539

Merged
MikeMcQuaid merged 1 commit into
mainfrom
outdated-disabled-packages
Nov 8, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
outdated-disabled-packages

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Exclude disabled formulae and casks because brew upgrade cannot install their newer versions.
  • Share filtering through their outdated? methods so brew outdated, brew update and minimum-version checks agree.
  • Keep deprecated packages eligible until their disable date.

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; every commit has a human author or co-author and I will answer maintainer questions and review comments myself without AI/LLM.

Codex with GPT 6 Astra at Extra High effort, with local review and testing.


- Exclude disabled formulae and casks because `brew upgrade` cannot
  install their newer versions.
- Share filtering through their `outdated?` methods so `brew outdated`,
  `brew update` and minimum-version checks agree.
- Keep deprecated packages eligible until their disable date.
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Bug Fixes
    • Disabled formulae and casks are no longer reported as outdated.
    • Outdated-package reports now omit disabled items, including when they are the only outdated packages.
    • Outdated checks now account for minimum-version requirements.

Formula and cask outdated checks now accept an optional minimum version and exclude disabled packages. The outdated command passes the minimum version to these checks. Tests cover package selection and update reports.

Changes: Outdated package selection

Layer / File(s) Summary
Outdated check methods and command integration
Library/Homebrew/formula.rb, Library/Homebrew/cask/cask.rb, Library/Homebrew/cmd/outdated.rb
Formula#outdated? and Cask#outdated? accept an optional minimum version and return false for disabled packages. select_outdated passes the minimum version to these methods.
Outdated selection and report tests
Library/Homebrew/test/cmd/outdated_spec.rb, Library/Homebrew/test/cmd/update-report_spec.rb
Tests cover disabled formulae and casks, packages with future disable dates, and reports that contain no output when only disabled packages are outdated.
Merge Risk: Minimal · up to 32759

Disabled packages remain excluded from the checked outdated-selection paths; no merge-blocking issue was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: disabled packages are skipped in outdated reports. It matches the summaries, which add disabled-item filtering to Formula#outdated? and Cask#outdated? and to select_ou…
Description check Passed The description states the purpose: disabled formulae and casks are excluded because brew upgrade cannot install their newer versions. It also explains that the filtering is shared through the outdate…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: disabled packages are skipped in outdated reports. It matches the summaries, which add disabled-item filtering to Formula#outdated? and Cask#outdated? and to select_outdated. The title is short, specific and in the imperative style.

Full details: Description check

Explanation

The description states the purpose: disabled formulae and casks are excluded because brew upgrade cannot install their newer versions. It also explains that the filtering is shared through the outdated? methods and that deprecated packages stay eligible until their disable date. These points match the changed files and tests.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 7a1df25e-177c-42c4-b881-1daf4bf4f8e2
Commits

Reviewing files that changed from the base of the PR and between 2ed8716 and 327599b.

Files selected for processing: 5

  • Library/Homebrew/cask/cask.rb
  • Library/Homebrew/cmd/outdated.rb
  • Library/Homebrew/formula.rb
  • Library/Homebrew/test/cmd/outdated_spec.rb
  • Library/Homebrew/test/cmd/update-report_spec.rb

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@MikeMcQuaid
MikeMcQuaid enabled auto-merge November 8, 2026 18:46

@HaraldNordgren HaraldNordgren left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Nov 8, 2026
Merged via the queue into main with commit 71c7a2a Nov 8, 2026
56 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the outdated-disabled-packages branch November 8, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址